Basically, just have something like this in your CSS:

.display-block {
display: block;
}

.display-none {
display: none;
}

and then apply it accordingly in your code.

If I want to just use the classnames all the way through how do I designate one for block and one for none? or would it just be easier to set inline styles on the repeater items?

Thanks again.

Thanks.
Your problem seems to rather stem from the fact that your element doesn’t have the style applied that you think; i.e. an element can be hidden from an external style sheet, but that doesn’t set its style.display property to “none”.

You can read more in Get the rendered style of an element.

So, you can either go down that windy road, or just work with classNames all the way through, i.e. one for block display and one for none.

Good luck!

function toggle_visibility(className) {
var e = getElementsByClassName(className, “div”, document);

for (var i = 0, len = e.length; i < len; ++i) {
if (e[i].style.display == ‘none’) {
e[i].style.display = ‘block’;
}
else {
e[i].style.display = ‘none’;
}
}
}

+ more

Great to hear, I’m glad it helped you!

I wanted to take advantage of some Firefox 3 features in our client, including the native `getElementsByClassName`. All was well and good, until our testers discovered some critical problems with Firefox 3, so we needed to step back to Firefox 2 (unfortunately). I still needed the gEBCN functionality, though, but I quickly discovered your implementation, dropped it in place, and it worked without any problems. This saved me a lot of time and energy. Thanks!

You’re specifying the parameters in the wrong order. The first one should be classname, the second tag name (optional) and the third parent element (optional). Like this:

getElementsByClassName('navigator', null, document);

i’m using your fabulous script but am getting the same error like Mazza on IE7 when calling it like this:

function hideall()
{
var boxnr = 0;
submenuboxes = getElementsByClassName(document, 'navigator');
while (submenuboxes[boxnr])
{
submenuboxes[boxnr].style.display = ‘none’;
boxnr++;
}
}

I’m hiding all div-containers with the class ‘navigator’ via onfocus-eventhandling and then view the active submenu-divcontainer ([...] onfocus=”hideall(); displayactivebox(’id’, ‘block’)”[...])

This works on all browsers except IE7, you got any idea to help me through this problem?
The submenus are neccessary, you know?

Turtle

Interesting. Hopefully MediaWiki will update their code. If not, please alert them.

As a follow-up to my post and our email correspondence, I looked more into the issue and I found out the root of the problem is that I am using your code on MediaWiki 1.11… looks like the folks of MediaWiki integrated either an old version or a hacked version of your getElementsByClassName into their wikibits.js file

Figured I would post this as a comment instead of email for anyone else that may think about adding this to their MediaWiki!

I’m glad that you like it!
Actually, it’s a minor flaw which was recently brought to my notice. "*" won’t work, like you say, just pass in null to be completely safe. Like this:

getElementsByClassName("desired-class", null, document.body);

I’ll fix this in the next release.

Thanks again for the function!

Great!